]> dgit.raspbian.org Git - gnome-shell.git/commit
dbusServices/extensions: Fix shutdown after showing prefs
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 28 Oct 2021 17:27:57 +0000 (19:27 +0200)
committerMarge Bot <marge-bot@gnome.org>
Sat, 30 Oct 2021 21:50:47 +0000 (21:50 +0000)
commit4d2b008966266ed96325dfd2cf7ebe41902aa270
tree176a6f6db7874787b417c201e5b454025998a75d
parent09ed1c533c2350b81e2c79f84998e8d3b4c1199a
dbusServices/extensions: Fix shutdown after showing prefs

GTK4 relies entirely on refcounting for cleanup (that is,
there is no longer a destroy() method that forces a dispose
run regardless of the refcount).

Unfortunately that makes cleanup harder in (some) language
bindings, where an object may be kept alive implicitly by
closures etc.

Address this by releasing the hold count when the window
is closed rather than when it is destroyed.

This isn't the most elegant, but it ensure that the service
doesn't get stuck if an extension doesn't carefully clean
up everything in its prefs widget.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4564

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2013>
js/dbusServices/extensions/extensionsService.js